Opening the NM classes to the public

Issues and feature requests
1

OpenRPA version: 1.4.57

Hi Allan,
i am currently developing some custom activities around element selection and since i am reusing your classes for the selector windows i realized that the OpenRpa.NM classes as set to internal, would it be a huge hassle for you to make them public so i can reference them in my own activities?
Specifically i am talking about NMSelector, NMHook, NM SelectorItem and so on.

For the OpenRpa.Windows classes this is already the case and i could use them fine.

I don’t really want to copy them in case you make changes later on.

Greetings Marvin

2

I don’t see any harm in that …
Can you do a PR with an update where you changed the classes you need to public ?

3

Hi Allan,
i have created the pull request for the 3 remaining internal classes. Right now i would only need NMSelector but i don’t see why we would leave the other 2 internal if the rest is public anyways and if i need them later on they are available.

Greetings Marvin

4

I have merged it and build a new version.

5

Thank you very much Allan.

6

This topic was automatically closed 3 days after the last reply. New replies are no longer allowed.