Cannot catch Business Rule Exceptions thrown in subflows

tvi · February 6, 2023, 9:20am

I noticed that Business Rule Exceptions thrown (using the throw business rule activity) in a Workflow that is invoked inside a try-catch activity cannot be caught as a OpenRPA.BusinessRuleException.

In my mind this must be a bug. If I throw it directly in the try-catch it is caught. When thrown in a subflow, it should propagate back to the calling flow (if not caught elsewhere), as if it had been thrown here.

I attached the example, but it is also very quick to reproduce from the description above.

Test Catch BusinessRuleException-Subflow.json (4.2 KB)
Test Catch BusinessRuleException.json (7.9 KB)

Kind regards,
Thomas

Allan_Zimmermann · February 6, 2023, 10:11am

If the exception was not cought, openrpa woudl crach and then it was a bug.
The problem is you need to “unwrap” it, by recursively checking InnerException til you find it
Update Workitem does this for you and make sure to set the correct errortype on the woritem

github.com

open-rpa/openrpa/blob/master/OpenRPA/Activities/Workitems/UpdateWorkitem.cs#L58


      
          if (t == null) throw new Exception("Missing Workitem");
          t.success_wiq = Success_wiq.Get<string>(context);
          t.failed_wiq = Failed_wiq.Get<string>(context);
          if (State != null && State.Expression != null)
          {
              var state = State.Get(context);
              if (!string.IsNullOrEmpty(state)) t.state = state;
          }
          if (ex != null)
          {
              while (ex.InnerException != null) ex = ex.InnerException;
              t.errormessage = ex.Message; t.errortype = "application";
              t.errorsource = ex.Source;
              if (ex is BusinessRuleException)
              {
                  t.errortype = "business";
              }
          }
          t.state = t.state.ToLower();
          if (!status.Contains(t.state)) throw new Exception("Illegal state on Workitem, must be successful, abandoned or retry");
          var result = await global.webSocketClient.UpdateWorkitem<Workitem>(t, files, ignoremaxretries, traceId, spanId);

tvi · February 6, 2023, 3:28pm

I do not see why OpenRPA will crash if the “Invoke OpenRPA” activity returns a OpenRPA.BusinessRuleException instead of a System.Exception when an OpenRPA.BusinessRuleException has been thrown inside of a sub-workflow.

I have made a pull request to fix the issue I described in the small example. In my mind this is entirely similar to the change made for “Invoke Code”.

Kind regards,
Thomas

tvi · February 6, 2023, 3:30pm

Sorry, not entirely similar to that issue, but the problem faced when throwing BusinessRuleExceptions inside “Invoke Code” was the same.

Allan_Zimmermann · February 6, 2023, 4:14pm

Not a bad idea … I like it … I will add that to next build

system · February 13, 2023, 4:15pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.